Oct 26 20:55:57 2001 Owen Taylor <otaylor@redhat.com>

        * gtk/gtkbutton.c: Revert changes to GTK_RUN_LAST.
        Unfortunately, people apparently erroneously connect
        to ::clicked for GtkToggleButton and expect
        they know what happened in the default signal handler
        instead of appropriately connecting to notification
        signal ::toggled. When the revolution comes, such
        people will be first against the wall.

        We'll just have to go back to the old less-reliable
        set-it-back hacks for handling model-view toggle
        buttons and entries. :-(.

diff --git a/ChangeLog b/ChangeLog
index 927c21e011f38a7d9c7a03f3bd58e208882201f2..5401e798badd5e666f2d49d385eb7073e6af3338 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,17 @@
+Fri Oct 26 20:55:57 2001  Owen Taylor  <otaylor@redhat.com>
+
+       * gtk/gtkbutton.c: Revert changes to GTK_RUN_LAST. 
+       Unfortunately, people apparently erroneously connect
+       to ::clicked for GtkToggleButton and expect
+       they know what happened in the default signal handler
+       instead of appropriately connecting to notification
+       signal ::toggled. When the revolution comes, such
+       people will be first against the wall.
+
+       We'll just have to go back to the old less-reliable
+       set-it-back hacks for handling model-view toggle
+       buttons and entries. :-(. 
+
 2001-10-27  Hans Breuer  <hans@breuer.org>
 
        * gtk/gtkbbox.c gtk/gtkctree.c gtk/gtkhbbox.c

diff --git a/ChangeLog.pre-2-0 b/ChangeLog.pre-2-0
index 927c21e011f38a7d9c7a03f3bd58e208882201f2..5401e798badd5e666f2d49d385eb7073e6af3338 100644 (file)
--- a/ChangeLog.pre-2-0
+++ b/ChangeLog.pre-2-0
@@ -1,3 +1,17 @@
+Fri Oct 26 20:55:57 2001  Owen Taylor  <otaylor@redhat.com>
+
+       * gtk/gtkbutton.c: Revert changes to GTK_RUN_LAST. 
+       Unfortunately, people apparently erroneously connect
+       to ::clicked for GtkToggleButton and expect
+       they know what happened in the default signal handler
+       instead of appropriately connecting to notification
+       signal ::toggled. When the revolution comes, such
+       people will be first against the wall.
+
+       We'll just have to go back to the old less-reliable
+       set-it-back hacks for handling model-view toggle
+       buttons and entries. :-(. 
+
 2001-10-27  Hans Breuer  <hans@breuer.org>
 
        * gtk/gtkbbox.c gtk/gtkctree.c gtk/gtkhbbox.c

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 927c21e011f38a7d9c7a03f3bd58e208882201f2..5401e798badd5e666f2d49d385eb7073e6af3338 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,17 @@
+Fri Oct 26 20:55:57 2001  Owen Taylor  <otaylor@redhat.com>
+
+       * gtk/gtkbutton.c: Revert changes to GTK_RUN_LAST. 
+       Unfortunately, people apparently erroneously connect
+       to ::clicked for GtkToggleButton and expect
+       they know what happened in the default signal handler
+       instead of appropriately connecting to notification
+       signal ::toggled. When the revolution comes, such
+       people will be first against the wall.
+
+       We'll just have to go back to the old less-reliable
+       set-it-back hacks for handling model-view toggle
+       buttons and entries. :-(. 
+
 2001-10-27  Hans Breuer  <hans@breuer.org>
 
        * gtk/gtkbbox.c gtk/gtkctree.c gtk/gtkhbbox.c

diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2
index 927c21e011f38a7d9c7a03f3bd58e208882201f2..5401e798badd5e666f2d49d385eb7073e6af3338 100644 (file)
--- a/ChangeLog.pre-2-2
+++ b/ChangeLog.pre-2-2
@@ -1,3 +1,17 @@
+Fri Oct 26 20:55:57 2001  Owen Taylor  <otaylor@redhat.com>
+
+       * gtk/gtkbutton.c: Revert changes to GTK_RUN_LAST. 
+       Unfortunately, people apparently erroneously connect
+       to ::clicked for GtkToggleButton and expect
+       they know what happened in the default signal handler
+       instead of appropriately connecting to notification
+       signal ::toggled. When the revolution comes, such
+       people will be first against the wall.
+
+       We'll just have to go back to the old less-reliable
+       set-it-back hacks for handling model-view toggle
+       buttons and entries. :-(. 
+
 2001-10-27  Hans Breuer  <hans@breuer.org>
 
        * gtk/gtkbbox.c gtk/gtkctree.c gtk/gtkhbbox.c

diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4
index 927c21e011f38a7d9c7a03f3bd58e208882201f2..5401e798badd5e666f2d49d385eb7073e6af3338 100644 (file)
--- a/ChangeLog.pre-2-4
+++ b/ChangeLog.pre-2-4
@@ -1,3 +1,17 @@
+Fri Oct 26 20:55:57 2001  Owen Taylor  <otaylor@redhat.com>
+
+       * gtk/gtkbutton.c: Revert changes to GTK_RUN_LAST. 
+       Unfortunately, people apparently erroneously connect
+       to ::clicked for GtkToggleButton and expect
+       they know what happened in the default signal handler
+       instead of appropriately connecting to notification
+       signal ::toggled. When the revolution comes, such
+       people will be first against the wall.
+
+       We'll just have to go back to the old less-reliable
+       set-it-back hacks for handling model-view toggle
+       buttons and entries. :-(. 
+
 2001-10-27  Hans Breuer  <hans@breuer.org>
 
        * gtk/gtkbbox.c gtk/gtkctree.c gtk/gtkhbbox.c

diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index 927c21e011f38a7d9c7a03f3bd58e208882201f2..5401e798badd5e666f2d49d385eb7073e6af3338 100644 (file)
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,3 +1,17 @@
+Fri Oct 26 20:55:57 2001  Owen Taylor  <otaylor@redhat.com>
+
+       * gtk/gtkbutton.c: Revert changes to GTK_RUN_LAST. 
+       Unfortunately, people apparently erroneously connect
+       to ::clicked for GtkToggleButton and expect
+       they know what happened in the default signal handler
+       instead of appropriately connecting to notification
+       signal ::toggled. When the revolution comes, such
+       people will be first against the wall.
+
+       We'll just have to go back to the old less-reliable
+       set-it-back hacks for handling model-view toggle
+       buttons and entries. :-(. 
+
 2001-10-27  Hans Breuer  <hans@breuer.org>
 
        * gtk/gtkbbox.c gtk/gtkctree.c gtk/gtkhbbox.c

diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index 927c21e011f38a7d9c7a03f3bd58e208882201f2..5401e798badd5e666f2d49d385eb7073e6af3338 100644 (file)
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,17 @@
+Fri Oct 26 20:55:57 2001  Owen Taylor  <otaylor@redhat.com>
+
+       * gtk/gtkbutton.c: Revert changes to GTK_RUN_LAST. 
+       Unfortunately, people apparently erroneously connect
+       to ::clicked for GtkToggleButton and expect
+       they know what happened in the default signal handler
+       instead of appropriately connecting to notification
+       signal ::toggled. When the revolution comes, such
+       people will be first against the wall.
+
+       We'll just have to go back to the old less-reliable
+       set-it-back hacks for handling model-view toggle
+       buttons and entries. :-(. 
+
 2001-10-27  Hans Breuer  <hans@breuer.org>
 
        * gtk/gtkbbox.c gtk/gtkctree.c gtk/gtkhbbox.c

diff --git a/gtk/gtkbutton.c b/gtk/gtkbutton.c
index eefc24f15c42b017f80efb998e0404da0351c22f..fa32a000388f340d5d716c62c9965a1d606e7071 100644 (file)
--- a/gtk/gtkbutton.c
+++ b/gtk/gtkbutton.c
@@ -212,42 +212,42 @@ gtk_button_class_init (GtkButtonClass *klass)
 
   button_signals[PRESSED] =
     gtk_signal_new ("pressed",
-                    GTK_RUN_LAST,
+                    GTK_RUN_FIRST,
                     GTK_CLASS_TYPE (object_class),
                     GTK_SIGNAL_OFFSET (GtkButtonClass, pressed),
                     gtk_marshal_VOID__VOID,
                    GTK_TYPE_NONE, 0);
   button_signals[RELEASED] =
     gtk_signal_new ("released",
-                    GTK_RUN_LAST,
+                    GTK_RUN_FIRST,
                     GTK_CLASS_TYPE (object_class),
                     GTK_SIGNAL_OFFSET (GtkButtonClass, released),
                     gtk_marshal_VOID__VOID,
                    GTK_TYPE_NONE, 0);
   button_signals[CLICKED] =
     gtk_signal_new ("clicked",
-                    GTK_RUN_LAST | GTK_RUN_ACTION,
+                    GTK_RUN_FIRST | GTK_RUN_ACTION,
                     GTK_CLASS_TYPE (object_class),
                     GTK_SIGNAL_OFFSET (GtkButtonClass, clicked),
                     gtk_marshal_VOID__VOID,
                    GTK_TYPE_NONE, 0);
   button_signals[ENTER] =
     gtk_signal_new ("enter",
-                    GTK_RUN_LAST,
+                    GTK_RUN_FIRST,
                     GTK_CLASS_TYPE (object_class),
                     GTK_SIGNAL_OFFSET (GtkButtonClass, enter),
                     gtk_marshal_VOID__VOID,
                    GTK_TYPE_NONE, 0);
   button_signals[LEAVE] =
     gtk_signal_new ("leave",
-                    GTK_RUN_LAST,
+                    GTK_RUN_FIRST,
                     GTK_CLASS_TYPE (object_class),
                     GTK_SIGNAL_OFFSET (GtkButtonClass, leave),
                     gtk_marshal_VOID__VOID,
                    GTK_TYPE_NONE, 0);
   button_signals[ACTIVATE] =
     gtk_signal_new ("activate",
-                    GTK_RUN_LAST,
+                    GTK_RUN_FIRST,
                     GTK_CLASS_TYPE (object_class),
                     GTK_SIGNAL_OFFSET (GtkButtonClass, activate),
                     gtk_marshal_VOID__VOID,